Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When closing an editor it does not reopen #94

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

fredmaggiowski
Copy link
Member

Checklist

  • your branch will not cause merge conflict with master
  • run npm test
  • [] tests are included
  • [] the documentation is updated or integrated accordingly with your changes
  • the code will follow the lint rules and style of the project
  • you are not committing extraneous files or sensible data

@fredmaggiowski
Copy link
Member Author

The problem is due to the fact that editor_holder and editjson_card_holder are set only under specific circumstances. While all other accesses where guarded by ifs, there were a few unchecked.

@fredmaggiowski
Copy link
Member Author

This is the error that appeared when clicking to expand the collapsed accordion

Schermata 2020-10-13 alle 13 37 18

@davidebianchi davidebianchi merged commit 0096864 into master Oct 13, 2020
@davidebianchi davidebianchi deleted the fix/collapsed-editor-does-not-reopen branch October 13, 2020 12:21
@davidebianchi
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants