Fix empty response body (#107)

mia-platform · Oct 7, 2021 · 9be6355 · 9be6355
1 parent c4c6e05
commit 9be6355
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 5 deletions.
diff --git a/packages/api-explorer/__tests__/ResponseBody.test.jsx b/packages/api-explorer/__tests__/ResponseBody.test.jsx
@@ -180,7 +180,7 @@ describe('Response body', () => {
       }}
       oas={oas}
     /></IntlProvider>);
-    
+
     const result = responseBody.find(Result);
 
     expect(result).toHaveLength(1);
@@ -198,7 +198,7 @@ describe('Response body', () => {
       }}
       oas={oas}
     /></IntlProvider>);
-    
+
     expect(responseBody.find(Result)).toHaveLength(0);
   });
 
@@ -230,6 +230,21 @@ describe('Response body', () => {
     expect(responseBody.find(Result)).toHaveLength(0);
   });
 
+  test('should not display Result if result.responseBody is empty', () => {
+    const responseBody = mount(<IntlProvider><ResponseBody
+      operation={oas.operation('/pet', 'post')}
+      isOauth
+      oauth={false}
+      result={{
+        status: 401,
+        responseBody: ''
+      }}
+      oas={oas}
+    /></IntlProvider>);
+
+    expect(responseBody.find(Result)).toHaveLength(0);
+  });
+
   test('should display message if OAuth is expired with oauth', () => {
     const responseBody = mount(<IntlProvider><ResponseBody {...oauthInvalidResponse} oas={oas} oauth /></IntlProvider>);
 

diff --git a/packages/api-explorer/src/components/Response/ResponseBody.jsx b/packages/api-explorer/src/components/Response/ResponseBody.jsx
@@ -49,15 +49,18 @@ Unauthorized.defaultProps = {
   isOauth: false,
 };
 
+const noBodyValues = [undefined, null, '']
+
 // eslint-disable-next-line react/prop-types
 function ResponseBody({ result, isOauth, oauth, isCollapsed}) {
   const { status, responseBody } = result;
+  const hasNoBody = noBodyValues.includes(responseBody)
   return (
     <div style={{ display: 'block', color: '#fff'}}>
       {status === 401 && <Unauthorized isOauth={isOauth} oauth={oauth} />}
-      {responseBody !== undefined && responseBody !== null ?
-        <Result result={result} isCollapse={isCollapsed} /> :
-        renderPlainText('response.noBody', 'The response has no body')
+      { hasNoBody ?
+        renderPlainText('response.noBody', 'The response has no body') :
+        <Result result={result} isCollapse={isCollapsed} />
       }
     </div>
   );

diff --git a/packages/api-explorer/webpack.config.js b/packages/api-explorer/webpack.config.js
@@ -29,4 +29,7 @@ module.exports = {
   resolve: {
     extensions: ['.js', '.json', '.jsx'],
   },
+  node: {
+    fs: "empty"
+  }
 };