Fix splitPath url regex to support single character params

Added tests
mia-platform · Jun 5, 2018 · 75311ec · 75311ec
1 parent dc7c99f
commit 75311ec
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/packages/api-explorer/__tests__/PathUrl.test.jsx b/packages/api-explorer/__tests__/PathUrl.test.jsx
@@ -3,6 +3,8 @@ const { shallow } = require('enzyme');
 const PathUrl = require('../src/PathUrl');
 const Oas = require('../src/lib/Oas');
 
+const { splitPath } = PathUrl;
+
 const { Operation } = Oas;
 const petstore = require('./fixtures/petstore/oas');
 
@@ -76,3 +78,12 @@ test('button click should call onSubmit', () => {
 
   expect(called).toBe(true);
 });
+
+describe('splitPath()', () => {
+  test('should work for multiple path params', () => {
+    expect(splitPath('/{a}/{b}/c').length).toBe(5);
+    expect(splitPath('/v1/flight/{FlightID}/sitezonetargeting/{SiteZoneTargetingID}').length).toBe(
+      4,
+    );
+  });
+});
diff --git a/packages/api-explorer/dist/index.js b/packages/api-explorer/dist/index.js
diff --git a/packages/api-explorer/src/PathUrl.jsx b/packages/api-explorer/src/PathUrl.jsx
@@ -10,7 +10,7 @@ const extensions = require('@readme/oas-extensions');
 
 function splitPath(path) {
   return path
-    .split(/({\w.+?})/)
+    .split(/({.+?})/)
     .filter(Boolean)
     .map(part => {
       return { type: part.match(/[{}]/) ? 'variable' : 'text', value: part.replace(/[{}]/g, '') };
@@ -107,3 +107,4 @@ PathUrl.defaultProps = {
   apiKey: '',
 };
 module.exports = PathUrl;
+module.exports.splitPath = splitPath;