Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(root): update cards, side navigation and top navigation code examples #639

Conversation

GCHQ-Developer-530
Copy link
Contributor

Summary of the changes

Update cards, side navigation and top navigation code examples to show how to use the badge slot.

Will need to build locally to test until the next release.

Related issue

#638

Checklist

@github-actions
Copy link

Copy link
Contributor

@GCHQ-Developer-299 GCHQ-Developer-299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-13 at 09 53 48

The badge doesn't appear in the code tab for Card

@GCHQ-Developer-530
Copy link
Contributor Author

GCHQ-Developer-530 commented Oct 13, 2023

Screenshot 2023-10-13 at 09 53 48

The badge doesn't appear in the code tab for Card

I think that's because the update for the card is still in develop so it doesn't know there's a slot for badge there yet so won't display it. You'll have to build and pack the components on the develop branch locally and install them on this branch for it to show up.

@GCHQ-Developer-299 GCHQ-Developer-299 dismissed their stale review October 13, 2023 13:45

Addressed by comment

…mples

Update cards, side navigation and top navigation code examples to show how to use the badge slot

. #638
@GCHQ-Developer-530 GCHQ-Developer-530 force-pushed the 638-add-code-examples-for-components-with-new-badge-slot branch from f364dda to 3336764 Compare October 16, 2023 08:42
@GCHQ-Developer-530 GCHQ-Developer-530 merged commit 6cc4848 into develop Oct 16, 2023
2 checks passed
@GCHQ-Developer-530 GCHQ-Developer-530 deleted the 638-add-code-examples-for-components-with-new-badge-slot branch October 16, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants