fix(root): changed tab behaviour on component pages #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your branch deployment here: https://animated-fiesta-gvyom1k.pages.github.io/branches/update-tab-navigation-behaviour |
GCHQ-Developer-741
force-pushed
the
update-tab-navigation-behaviour
branch
10 times, most recently
from
f6ccf0d to
a66d240
Compare
GCHQ-Developer-530
previously approved these changes
Oct 5, 2023
GCHQ-Developer-741
force-pushed
the
update-tab-navigation-behaviour
branch
from
31db7b2 to
adbb0be
Compare
changed tab behaviour to use gatsby links to preserve urls, whilst applying focus to new tab after page load to preserve position on page
GCHQ-Developer-741
force-pushed
the
update-tab-navigation-behaviour
branch
from
adbb0be to
87f02fb
Compare
runs effect on page load to focus tab & set active class. also fixes applying active class to tab when anchor link clicked
GCHQ-Developer-741
force-pushed
the
update-tab-navigation-behaviour
branch
from
87f02fb to
9654c22
Compare
fixes focus when nav link clicked or tab in page header in component view
…esign-system into update-tab-navigation-behaviour
GCHQ-Developer-465
approved these changes
Oct 6, 2023
GCHQ-Developer-530
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Removed previous code that involved updating the tab content manually on component pages, so that they now function using Gatsby Links to preserve the url and Anchor Nav behaviour.
Added some additional code to focus the clicked tab when moving between the code, guidance and accessibility content, to preserve position on the page for keyboard users
Related issue
#563
Checklist