Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(root): fixes issues spotted on v3 site #1254

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(root): fixes issues spotted on v3 site #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/components/SubsectionNav/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,6 @@ const SubsectionNav: React.FC<SubsectionNavProps> = ({
tooltip?.setExternalPopperProps({
strategy: "fixed",
});
const pageHeader = document.querySelector("ic-page-header");
if (pageHeader && pageHeader.getAttribute("sticky-desktop-only")) {
pageHeader.classList.add("temp-remove-sticky");
}
};

const handleMouseOut = () => {
const pageHeader = document.querySelector("ic-page-header");
if (pageHeader && pageHeader.getAttribute("sticky-desktop-only")) {
pageHeader.classList.remove("temp-remove-sticky");
}
};

// eslint-disable-next-line no-undef
Expand Down Expand Up @@ -169,7 +158,6 @@ const SubsectionNav: React.FC<SubsectionNavProps> = ({
selected={!hasChildren && isCurrentPage(item.data.fields.slug, false)}
expanded={hasChildren && isChildSelected(item)}
onMouseOver={handleMouseOver}
onMouseOut={handleMouseOut}
onIcTreeItemSelected={() =>
sessionStorage.setItem("navlinkclick", "true")
}
Expand Down
16 changes: 9 additions & 7 deletions src/content/structured/get-started/install-components.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,15 @@ npm install @ukic/react @ukic/fonts
variant="warning"
>
<span slot="message">
When the ic-theme component is not implemented, components will default to
the user's system colour scheme. Please keep this in mind when styling your
application. See the{" "}
<ic-link href="/get-started/install-components/custom-theme/#dark-mode-as-a-theme">
theming guidance
</ic-link>{" "}
for more information.
<ic-typography>
When the ic-theme component is not implemented, components will default to
the user's system colour scheme. Please keep this in mind when styling your
application. See the{" "}
<ic-link href="/get-started/install-components/custom-theme/#dark-mode-as-a-theme">
theming guidance
</ic-link>{" "}
for more information.
</ic-typography>
</span>
</IcAlert>

Expand Down
4 changes: 0 additions & 4 deletions src/templates/CoreTemplate/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ video.half-width {
width: 48.5%;
}

ic-page-header.temp-remove-sticky {
position: static;
}

@media screen and (max-width: 768px) {
.page-container {
margin-bottom: var(--ic-space-xxl);
Expand Down
Loading