Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(root): add options array to code example #1219

Conversation

otutukingsley
Copy link
Contributor

Summary of the changes

Added the options array in the multi-select component code examples to fix the issue where the options array was not defined, causing errors when using the component.

Related issue

Fixes issue #1198

Checklist

@otutukingsley otutukingsley changed the title feat(multi-select): add options array to code example fix(root): add options array to code example Nov 24, 2024
@otutukingsley otutukingsley force-pushed the ic-select-with-multi-code-example-fix branch from b83b32f to 64c653d Compare November 24, 2024 16:48
@otutukingsley
Copy link
Contributor Author

@gd2910 you can reference this ticket for issue #1198

@GCHQ-Developer-847
Copy link
Contributor

Hi @otutukingsley, thank you for your contribution! It looks like the audit check is failing - this should be fixed on the develop branch so if you rebase your branch onto it, that should sort it

This commit adds an options array to the Multi-Select component example to enhance usability and ensure accurate code representation.

Refs: mi6#1198
@otutukingsley otutukingsley force-pushed the ic-select-with-multi-code-example-fix branch from 64c653d to fee1de5 Compare December 4, 2024 12:56
@otutukingsley
Copy link
Contributor Author

Hi @otutukingsley, thank you for your contribution! It looks like the audit check is failing - this should be fixed on the develop branch so if you rebase your branch onto it, that should sort it

This should be good now.

Copy link
Contributor

@GCHQ-Developer-847 GCHQ-Developer-847 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@GCHQ-Developer-847 GCHQ-Developer-847 merged commit 907aa90 into mi6:develop Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants