docs(root): add guidance for neutral alert and show default icon prop #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your branch deployment here: https://mi6.github.io/ic-design-system-githubpages/branches/guidance/1126-add-guidance-for-neutral-alert |
lz405
force-pushed
the
guidance/1126-add-guidance-for-neutral-alert
branch
from
b9f364d to
b4a924a
Compare
ad9242
previously requested changes
Oct 17, 2024
lz405
force-pushed
the
guidance/1126-add-guidance-for-neutral-alert
branch
from
b4a924a to
2d0d4ab
Compare
add examples for neutral variant alerts and alerts with the show-default-icon prop set to false fix #1126
lz405
force-pushed
the
guidance/1126-add-guidance-for-neutral-alert
branch
from
2d0d4ab to
e886f1f
Compare
MI6-286
approved these changes
Oct 21, 2024
GCHQ-Developer-847
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Noticed the issue with the margin when showDefaultIcon is false but I know it will be fixed by PR #2616 so have approved :)
GCHQ-Developer-299
force-pushed
the
develop
branch
from
ed89ace to
ec4dc29
Compare
gd2910
approved these changes
Nov 7, 2024
GCHQ-Developer-299
deleted the
guidance/1126-add-guidance-for-neutral-alert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Add guidance for neutral alert and show default icon prop.
Related issue
Issue #1126
Checklist