Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ic-select] Code preview mismatch #1052

Closed
gd2910 opened this issue Jul 11, 2024 · 0 comments
Closed

[ic-select] Code preview mismatch #1052

gd2910 opened this issue Jul 11, 2024 · 0 comments
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before select component The related component page type: bug 🐛 An unexpected problem or unintended behaviour
Milestone
Future Release

Comments

@gd2910
Copy link
Contributor

gd2910 commented Jul 11, 2024

Summary of the bug

The code preview currently show the incorrect object type for the example. The option in the example include a description

📸 Screenshots or code

image

🧐 Expected behaviour

Change the options object in the code example to match the component preview
@gd2910 gd2910 added type: bug 🐛 An unexpected problem or unintended behaviour good first issue A good starter issue if you haven't contributed to the ICDS before select component The related component page labels Jul 11, 2024
@MI6-255 MI6-255 added this to the Future Release milestone Aug 28, 2024
lz405 added a commit that referenced this issue Sep 4, 2024
@lz405
fix: fix code preview difference from code snippet
655ffc9 
fix #1052
lz405 added a commit that referenced this issue Sep 4, 2024
@lz405
fix: update code snippet for options disabled preview on ic select
05109e4 
fix #1052
@lz405 lz405 mentioned this issue Sep 5, 2024
Merged
2 tasks
lz405 added a commit that referenced this issue Sep 5, 2024
@lz405
fix: fix code snippet mismatch with preview
452786e 
fix #1052
@ad9242 ad9242 closed this as completed in 1ef01c0 Sep 23, 2024
@github-project-automation github-project-automation bot moved this from In Refinement to Done in Intelligence Community Design System Sep 23, 2024
GCHQ-Developer-299 pushed a commit that referenced this issue Dec 9, 2024
@lz405 @GCHQ-Developer-299
fix(root): update code snippets to match code previews
519682e 
fix #1052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before select component The related component page type: bug 🐛 An unexpected problem or unintended behaviour
Projects
Intelligence Community Design System
Status: Done
Milestone
Future Release
Development

No branches or pull requests
2 participants
@MI6-255 @gd2910