Merge pull request #1254 from mi6/v3-site-fixes

fix(root): fixes issues spotted on v3 site
mi6 · Dec 13, 2024 · df29ea4 · df29ea4
2 parents 4f9aca9 + c5cfd7d
commit df29ea4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 23 deletions.
diff --git a/src/components/SubsectionNav/index.tsx b/src/components/SubsectionNav/index.tsx
@@ -128,17 +128,6 @@ const SubsectionNav: React.FC<SubsectionNavProps> = ({
       tooltip?.setExternalPopperProps({
         strategy: "fixed",
       });
-      const pageHeader = document.querySelector("ic-page-header");
-      if (pageHeader && pageHeader.getAttribute("sticky-desktop-only")) {
-        pageHeader.classList.add("temp-remove-sticky");
-      }
-    };
-
-    const handleMouseOut = () => {
-      const pageHeader = document.querySelector("ic-page-header");
-      if (pageHeader && pageHeader.getAttribute("sticky-desktop-only")) {
-        pageHeader.classList.remove("temp-remove-sticky");
-      }
     };
 
     // eslint-disable-next-line no-undef
@@ -169,7 +158,6 @@ const SubsectionNav: React.FC<SubsectionNavProps> = ({
         selected={!hasChildren && isCurrentPage(item.data.fields.slug, false)}
         expanded={hasChildren && isChildSelected(item)}
         onMouseOver={handleMouseOver}
-        onMouseOut={handleMouseOut}
         onIcTreeItemSelected={() =>
           sessionStorage.setItem("navlinkclick", "true")
         }

diff --git a/src/content/structured/get-started/install-components.mdx b/src/content/structured/get-started/install-components.mdx
@@ -43,13 +43,15 @@ npm install @ukic/react @ukic/fonts
   variant="warning"
 >
   <span slot="message">
-    When the ic-theme component is not implemented, components will default to
-    the user's system colour scheme. Please keep this in mind when styling your
-    application. See the{" "}
-    <ic-link href="/get-started/install-components/custom-theme/#dark-mode-as-a-theme">
-      theming guidance
-    </ic-link>{" "}
-    for more information.
+    <ic-typography>
+      When the ic-theme component is not implemented, components will default to
+      the user's system colour scheme. Please keep this in mind when styling your
+      application. See the{" "}
+      <ic-link href="/get-started/install-components/custom-theme/#dark-mode-as-a-theme">
+        theming guidance
+      </ic-link>{" "}
+      for more information.
+    </ic-typography>
   </span>
 </IcAlert>
 

diff --git a/src/templates/CoreTemplate/index.css b/src/templates/CoreTemplate/index.css
@@ -60,10 +60,6 @@ video.half-width {
   width: 48.5%;
 }
 
-ic-page-header.temp-remove-sticky {
-  position: static;
-}
-
 @media screen and (max-width: 768px) {
   .page-container {
     margin-bottom: var(--ic-space-xxl);