Merge pull request #1237 from mi6/remove-missing-attributes

fix(root): removed attribute sections if they aren't included
mi6 · Dec 4, 2024 · 327fb20 · 327fb20
2 parents 7e98694 + 7e19b41
commit 327fb20
Show file tree

Hide file tree

Showing 5 changed files with 843 additions and 832 deletions.
diff --git a/src/components/ComponentDetails/AttributeName/index.tsx b/src/components/ComponentDetails/AttributeName/index.tsx
@@ -6,12 +6,17 @@ const AttributeName: React.FC<{
   value: (string | undefined)[];
 }> = ({ name, value }) => (
   <div className="attribute-name">
-    {name.map((attributeName, i) => (
-      <div key={`attribute-${attributeName.toLowerCase().split(" ")[0]}`}>
-        <ic-typography variant="subtitle-small">{attributeName}</ic-typography>
-        <ic-typography variant="subtitle-large">{value[i]}</ic-typography>
-      </div>
-    ))}
+    {name.map(
+      (attributeName, i) =>
+        value[i] && (
+          <div key={`attribute-${attributeName.toLowerCase().split(" ")[0]}`}>
+            <ic-typography variant="subtitle-small">
+              {attributeName}
+            </ic-typography>
+            <ic-typography variant="subtitle-large">{value[i]}</ic-typography>
+          </div>
+        )
+    )}
   </div>
 );
 

diff --git a/src/components/Layout/index.tsx b/src/components/Layout/index.tsx
@@ -273,7 +273,7 @@ const Layout: React.FC<LayoutProps> = ({
                   {footerLink.text}
                 </ic-footer-link>
               ))}
-            <div slot="logo" className="logo-wrapper">
+            <div slot="logo" className="logo-wrapper" role="list">
               <ic-footer-link href="https://sis.gov.uk">
                 <SISLogo aria-hidden="true" />
                 <span className="link-text">Go to S.I.S. website</span>

diff --git a/src/content/structured/components/footer/code.mdx b/src/content/structured/components/footer/code.mdx
@@ -226,7 +226,7 @@ export const snippetsLogoLinks = [
   <ic-footer-link slot="link" href="#">Styles</ic-footer-link>
   <ic-footer-link slot="link" href="#">Components</ic-footer-link>
   <ic-footer-link slot="link" href="#">Patterns</ic-footer-link>
-    <div slot="logo">
+    <div slot="logo" role="list">
       <ic-footer-link href="#">
         <svg xmlns="http://www.w3.org/2000/svg"
           height="48"
@@ -267,7 +267,7 @@ export const snippetsLogoLinks = [
   <IcFooterLink slot="link" href="#">Styles</IcFooterLink>
   <IcFooterLink slot="link" href="#">Components</IcFooterLink>
   <IcFooterLink slot="link" href="#">Patterns</IcFooterLink>
-  <div slot="logo">
+  <div slot="logo" role="list">
     <IcFooterLink href="#">
       <SlottedSVG
         xmlns="http://www.w3.org/2000/svg"
@@ -332,6 +332,7 @@ export const snippetsLogoLinks = [
         display: "flex",
         gap: "var(--ic-space-lg)",
       }}
+      role="list"
     >
       <IcFooterLink href="#">
         <svg

diff --git a/src/content/structured/components/popover-menu/guidance.mdx b/src/content/structured/components/popover-menu/guidance.mdx
@@ -63,7 +63,12 @@ export const IntroPopover = () => {
           <path d="M9.5 13a1.5 1.5 0 1 1-3 0 1.5 1.5 0 0 1 3 0zm0-5a1.5 1.5 0 1 1-3 0 1.5 1.5 0 0 1 3 0zm0-5a1.5 1.5 0 1 1-3 0 1.5 1.5 0 0 1 3 0z" />
         </svg>
       </IcButton>
-      <IcPopoverMenu anchor="button-1" aria-label="popover" open={popoverOpen} onIcPopoverClosed={handlePopoverClosed}>
+      <IcPopoverMenu
+        anchor="button-1"
+        aria-label="popover"
+        open={popoverOpen}
+        onIcPopoverClosed={handlePopoverClosed}
+      >
         <IcMenuItem label="Copy code" />
         <IcMenuItem label="Paste code" />
         <IcMenuItem label="Actions" submenuTriggerFor="actions" />