Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubSystem Implementation #2

Open
mhughes2k opened this issue Mar 4, 2022 · 1 comment
Open

SubSystem Implementation #2

mhughes2k opened this issue Mar 4, 2022 · 1 comment
Assignees
@mhughes2k

Comments

@mhughes2k
Copy link
Owner

mhughes2k commented Mar 4, 2022 •
edited
Loading

We want the BetterGroups to be a drop-in replacement for Moodle's current Group system in the /group directory.

So we're putting this in a "side-by-side" directory "groupng".
@mhughes2k
Copy link
Owner Author

This also needs an entry in the {{lib/components.json}} file.

@mhughes2k mhughes2k self-assigned this Mar 4, 2022
@mhughes2k mhughes2k moved this from Todo to In Progress in Better Moodle Groups Mar 4, 2022
mhughes2k pushed a commit that referenced this issue Mar 8, 2024
@sarjona
MDL-80950 external: Fix PHP deprecated error for explode()
fc191c7 
This patch fixes the following error:
PHP Deprecated:  explode(): Passing null to parameter #2 ($string)
of type string is deprecated in lib/upgradelib.php on line 1299
mhughes2k pushed a commit that referenced this issue Jun 21, 2024
@stronk7
MDL-81522 phpunit: Add missing void return type to all tests #2
4f76311 
This commit includes more changes, all them also adding the :void
return type to unit tests missing them.

The difference is that all these changes, while also detected
perfectly by the moodle.PHPUnit.TestReturnType sniff, were not
auto-fixed (like the previous commit ones), because all them
do include some "return" statement and, for safety, we don't
fix them.

All the cases have been visually inspected and confirmed that
the existing "return" statements always belong to anon
functions within the test body and not the test own return statement.
mhughes2k pushed a commit that referenced this issue Aug 1, 2024
@sarjona
MDL-80950 external: Fix PHP deprecated error for explode()
e5ead3c 
This patch fixes the following error:
PHP Deprecated:  explode(): Passing null to parameter #2 ($string)
of type string is deprecated in lib/upgradelib.php on line 1299
mhughes2k pushed a commit that referenced this issue Aug 1, 2024
@sarjona
MDL-80950 external: Fix PHP deprecated error for explode()
63d96ee 
This patch fixes the following error:
PHP Deprecated:  explode(): Passing null to parameter #2 ($string)
of type string is deprecated in lib/upgradelib.php on line 1299
mhughes2k pushed a commit that referenced this issue Aug 1, 2024
@stronk7
MDL-81522 phpunit: Add missing void return type to all tests #2
091b458 
This commit includes more changes, all them also adding the :void
return type to unit tests missing them.

The difference is that all these changes, while also detected
perfectly by the moodle.PHPUnit.TestReturnType sniff, were not
auto-fixed (like the previous commit ones), because all them
do include some "return" statement and, for safety, we don't
fix them.

All the cases have been visually inspected and confirmed that
the existing "return" statements always belong to anon
functions within the test body and not the test own return statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhughes2k mhughes2k

Labels
None yet
Projects
Better Moodle Groups
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhughes2k