Add abstract jobs for FinalizationGroup and WeakRef

Implement processing model changes from tc39/proposal-weakrefs#86 Cleanup jobs and clear kept objects tasks are now properly enqueued Avoid iterating over non-empty cells when cleaning a group Spec change: cleanupSome no longer invokes callback if no empty cells
mhofman · May 7, 2019 · 86a7b28 · 86a7b28
1 parent 68fca44
commit 86a7b28
Show file tree

Hide file tree

Showing 23 changed files with 674 additions and 608 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -8,7 +8,7 @@
       "runtimeArgs": [
         "--expose-gc",
         "--require", "esm",
-        "--require", "${workspaceFolder}/tests/setup.node.js",
+        "--require", "${workspaceFolder}/tests/setup.node.cjs",
          ],
       "program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
       "args": [

diff --git a/src/index.ts b/src/index.ts
@@ -11,11 +11,12 @@ function testKnownImplementationIssues(
     try {
         const finalizationGroup = new FinalizationGroup(() => {});
         if (finalizationGroup.unregister({}) !== false) return false;
-        let called = false;
-        finalizationGroup.cleanupSome(() => {
-            called = true;
-        });
-        if (!called) return false;
+        // TBD: Figure out how to test for broken cleanupSome
+        // let called = false;
+        // finalizationGroup.cleanupSome(() => {
+        //     called = true;
+        // });
+        // if (!called) return false;
     } catch (err) {
         return false;
     }

diff --git a/src/internal/Agent.mock.ts b/src/internal/Agent.mock.ts
diff --git a/src/internal/Agent.test.ts b/src/internal/Agent.test.ts
diff --git a/src/internal/Agent.ts b/src/internal/Agent.ts
diff --git a/src/internal/AgentFinalizationJobScheduler.ts b/src/internal/AgentFinalizationJobScheduler.ts