Do not use strcpy to copy 2 char

Given `char src` and `char dst`, one should copy them like `dst = src`, not like `strcpy(&dst, &src)`. Fixes rapidsai#847.
mhoemmen · Sep 27, 2022 · 694deda · 694deda
1 parent 1dd2feb
commit 694deda
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/cpp/include/raft/linalg/detail/svd.cuh b/cpp/include/raft/linalg/detail/svd.cuh
@@ -66,15 +66,9 @@ void svdQR(const raft::handle_t& handle,
   char jobu  = 'S';
   char jobvt = 'A';
 
-  if (!gen_left_vec) {
-    char new_u = 'N';
-    strcpy(&jobu, &new_u);
-  }
+  if (!gen_left_vec) { jobu = 'N'; }
 
-  if (!gen_right_vec) {
-    char new_vt = 'N';
-    strcpy(&jobvt, &new_vt);
-  }
+  if (!gen_right_vec) { jobvt = 'N'; }
 
   RAFT_CUSOLVER_TRY(cusolverDngesvd(cusolverH,
                                     jobu,