Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close, minimize and full screen buttons for the calculator app. #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MV194
Copy link

@MV194 MV194 commented Jul 3, 2024

Good afternoon,

This project is an amazing idea, if I had this idea I would work on it for ever. Anyway, I have added an event listener so that once the minimize and full screen buttons on the calculator app is clicked the calculator follows the function which is to make it bigger and smaller. I don't know if you would like that but I believe that it is a good idea to make the calculator app to have the same full screen, minimize and close options as the other apps.

Good luck!!

This project is an amazing idea, if I had this idea I would work on it for ever.
Anyway, I have added an event listener so that once the minimize and full screen buttons on the calculator app is clicked the calculator follows the function which is to make it bigger and smaller.
I don't know if you would like that but I believe that it is a good idea to make the calculator app to have the same full screen, minimize and close options as the other apps.

Good luck!!
@mhmdmhd6
Copy link
Owner

Hi,

Thank you for your contribution and for the event listener addition! It's a great idea to make the calculator app more dynamic. However, to keep the app consistent with macOS design principles, the calculator does not typically have a fullscreen option. The Calculator app can be resized, but it doesn't support a dedicated fullscreen mode like other macOS apps.

I also have plans to relaunch this project using React, which will allow for easier development and the addition of more features. I appreciate your effort and enthusiasm. Let's discuss how we can align this feature with the macOS experience while considering the future direction of the project.

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants