Skip to content

Commit

Permalink
Revert "ginkgo-v2 cleanup workaround for containers#18180"
Browse files Browse the repository at this point in the history
This reverts commit c4b9f4b.

This was a temporary workaround until a fix for containers#18180 landed.

Signed-off-by: Matthew Heon <[email protected]>
  • Loading branch information
mheon committed Jun 1, 2023
1 parent ef1a22c commit bafb3d6
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions test/e2e/common_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -652,12 +652,7 @@ func (p *PodmanTestIntegration) Cleanup() {
// An error would cause it to stop and return early otherwise.
Expect(stop).To(Exit(0), "command: %v\nstdout: %s\nstderr: %s", stop.Command.Args, stop.OutputToString(), stop.ErrorToString())
Expect(podrm).To(Exit(0), "command: %v\nstdout: %s\nstderr: %s", podrm.Command.Args, podrm.OutputToString(), podrm.ErrorToString())

// FIXME: Remove this special case when the issue is fixed.
// Special case rm -fa is not working correctly with dependencies, https://github.com/containers/podman/issues/18180
if !strings.Contains(rmall.ErrorToString(), "has dependent containers which must be removed before it") {
Expect(rmall).To(Exit(0), "command: %v\nstdout: %s\nstderr: %s", rmall.Command.Args, rmall.OutputToString(), rmall.ErrorToString())
}
Expect(rmall).To(Exit(0), "command: %v\nstdout: %s\nstderr: %s", rmall.Command.Args, rmall.OutputToString(), rmall.ErrorToString())
}

// CleanupVolume cleans up the volumes and containers.
Expand Down

0 comments on commit bafb3d6

Please sign in to comment.