getContainerNetworkInfo: lock netNsCtr before sync

`syncContainer()` requires the container to be locked, otherwise we can end up with undefined behavior. [NO TESTS NEEDED] Signed-off-by: Paul Holzinger <[email protected]>
mheon · Jun 24, 2021 · ab5e770 · ab5e770
1 parent b957bff
commit ab5e770
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/libpod/networking_linux.go b/libpod/networking_linux.go
@@ -866,6 +866,10 @@ func (c *Container) getContainerNetworkInfo() (*define.InspectNetworkSettings, e
 		if err != nil {
 			return nil, err
 		}
+		// see https://github.com/containers/podman/issues/10090
+		// the container has to be locked for syncContainer()
+		netNsCtr.lock.Lock()
+		defer netNsCtr.lock.Unlock()
 		// Have to sync to ensure that state is populated
 		if err := netNsCtr.syncContainer(); err != nil {
 			return nil, err