Skip to content

Commit

Permalink
Ensure sig-proxy default is propagated in start
Browse files Browse the repository at this point in the history
We properly determined what sig-proxy should be set to, but we
never passed that along to the backend. As such, cases where the
default swapped (mostly when `--attach` was specified but the
`--sig-proxy` flag was not) were not handled correctly

Fixes containers#6928

Signed-off-by: Matthew Heon <[email protected]>
  • Loading branch information
mheon committed Jul 22, 2020
1 parent 24f0175 commit 0030dd3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cmd/podman/containers/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ func start(cmd *cobra.Command, args []string) error {
if cmd.Flag("sig-proxy").Changed {
sigProxy = startOptions.SigProxy
}
startOptions.SigProxy = sigProxy

if sigProxy && !startOptions.Attach {
return errors.Wrapf(define.ErrInvalidArg, "you cannot use sig-proxy without --attach")
Expand Down

0 comments on commit 0030dd3

Please sign in to comment.