Avoid skipping ranges when looping through queues #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebasing with master will give you a green build on the first two PRs. |
mhenrixon
approved these changes
Jun 30, 2022
francesmcmullin
force-pushed
the
bug/reap-growing-queues
branch
from
dbe5362 to
8f918c7
Compare
|
Whatever is left is all on you 😋 |
auto-merge was automatically disabled
June 30, 2022 14:06
Head branch was pushed to by a user without write access
francesmcmullin
force-pushed
the
bug/reap-growing-queues
branch
from
8f918c7 to
62cfab4
Compare
|
Green now 🎉 🟢 Thanks for the nudge ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When queues are very full and/or very active, the ruby reaper can't give absolute guarantees because it doesn't run as a single atomic action, but we can eliminate some edge cases.
In this instance, the reaper anticipates that a queue might empty, from the front, in which case ranges need to be adjusted downward to ensure every job is checked. However, in the case where the queue grows (at the back), this calculation of "next_page - (initial_size - current_size))" means skipping over some jobs.