Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote '3.0' to ensure CI uses Ruby 3.0.x for the 3.0 entry #689

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Quote '3.0' to ensure CI uses Ruby 3.0.x for the 3.0 entry #689

merged 4 commits into from
Apr 2, 2022

Conversation

petergoldstein
Copy link
Contributor

The 3.0 in the CI configuration needs to be quoted or it will be truncated to '3'. This loads the latest Ruby 3 version, which at time of writing is Ruby 3.1.1.

See a recent CI run:

Screen Shot 2022-03-10 at 8 15 18 PM

@petergoldstein
Copy link
Contributor Author

As a note, the spec failures here are unrelated to this change. Broadly the failures appear to be the result of two items:

  1. New linter(s) in rubocop-rspec
  2. The elimination of Sidekiq::DEFAULT_WORKER_OPTIONS and related method renaming - Sidekiq Changelog

@petergoldstein
Copy link
Contributor Author

@mhenrixon If you want I can try and fix all of these outstanding issues. Just let me know.

@mhenrixon mhenrixon merged commit 9d44414 into mhenrixon:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants