Add extension to Sidekiq API that is uniqueness-aware #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, I'd love to get this merged in and released but I just merged another really good pull request that is solving some of the same problems. Could you rebase against my master and force push those changes? I am pretty sure the build should then pass. |
* master: Upgrade rspec Remove incompatible gemsd Add support for ruby 1.9.3 in development mode freezing version to sidekiq 3.0 Unlock testing inline jobs like normal ones
|
Done, and I didn't even have to force push. :) |
|
Gah thats what I get for refactoring :) I'll merge this manually! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds an extension, that is not required by default.
If it gets required, Job.delete and Queue.clear delete the corresponding uniqueness locks from redis, so that deletions from the web GUI allow new jobs to be created,
The idea and most of the extension code come from krasnoukhov/sidekiq-middleware#27