Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make locks more robust #277

Merged
merged 23 commits into from
Jun 25, 2018
Merged

Make locks more robust #277

merged 23 commits into from
Jun 25, 2018

Conversation

mhenrixon
Copy link
Owner

@mhenrixon mhenrixon commented Jun 22, 2018 •
edited
Loading

  • There was an issue removing locks after using them successfully
  • Some locks didn't get removed at all
  • Minor testing improvements
  • Use the JID as token

@mhenrixon mhenrixon added this to the Version 6 milestone Jun 22, 2018
@mhenrixon mhenrixon self-assigned this Jun 22, 2018
mhenrixon added 21 commits June 23, 2018 09:27
@mhenrixon
Create a file per shared example
7f9f9fd
@mhenrixon
Ignore all ruby files in spec directory
fa35fd8
@mhenrixon
More unit tests for locks
adf7649
@mhenrixon
Only execute certain jobs when they are locked?
0ac2fc6
@mhenrixon
Don't redefine variable
3dc3802
@mhenrixon
Test both ruby and lua version
50f220f
@mhenrixon
Remove last trace of mock_redis
16f38ac
@mhenrixon
Allow coverage to drop
0dc597d
@mhenrixon
Don't allow stale lock cleanup
a0cff5b
@mhenrixon
Remove unused constants
fd426fe
@mhenrixon
Align assignments
ce56302
@mhenrixon
Add comment about when stale checking was removed
85dd493
@mhenrixon
Use runtime_lock
0389c3b
@mhenrixon
Improve testing the locks
345756f
@mhenrixon
Fix a race condition
aa838ae 
The locksmith was created before the item was fully prepared for the runtime
lock.
@mhenrixon
Use guard with one gemfile only
416d631
@mhenrixon
Adds a changelog entry
f94d850
@mhenrixon
Remove some stink configuration
16ea376
@mhenrixon
Refresh readme [ci-skip]
2d8e02d
@mhenrixon
Remove unused method
cd180c8
@mhenrixon
Rename to unique_digest
0a15cfd 
This goes better with what it actually is
@mhenrixon mhenrixon merged commit 524d697 into master Jun 25, 2018
@mhenrixon mhenrixon deleted the make-lock-execute-fool-proof branch June 25, 2018 04:59
@JacobEvelyn JacobEvelyn mentioned this pull request May 14, 2019
Closed
@JacobEvelyn JacobEvelyn mentioned this pull request May 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhenrixon mhenrixon

Labels
enhancement master
Projects
None yet
Milestone
Version 6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mhenrixon