Use hscan for Util#expire #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to be able to report the deleted keys, I will get this merged and maybe you could create a second PR for the silently_expire? |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large apps,
hgetallcan take forever which will block Redis and suspend any Sidekiq job execution. Usehscaninstead.A question: is it useful to report the
removed_keys? The issue is that with a huge app collecting all the IDs this will end up cloninguniquekeysin RAM on the app server. One of our production apps has a multi-gigabyteuniquekeyshash and runningexpirewill kill it. If this is useful, I could add something likeUtil#silently_expirewith a matching Rake task.