Compatibility with Sidekiq 2.12.1 Scheduled Jobs

[lsimoneau]

Sidekiq 2.12.1 now calls middleware when queueing scheduled jobs. This causes issues with unique-jobs: a key is stored when the job is initially scheduled, then when the job is removed from the schedule and queued, unique-jobs stops it because they key is present.

This works around the problem by storing a different value (2) in the job hash for jobs that are being scheduled. When a new job is being processed, if it was previously scheduled but is now being queued, we let it through.

[deckchairhq]

There's another issue hidden under the covers with this version: krasnoukhov/sidekiq-middleware#12 (comment)

[felixyz]

Is anyone working on a fix for the issue @thinkgareth linked to? If I understand correctly, the solution (according to @mperham) is that: "Client middleware needs to handle both Class or String as the first argument."

[felixyz]

@mhenrixon Are you planning to make a new gem release within a few days with this fix in it? I'd appreciate it, for one... :)

[rajagopals]

I still get the error mentioned by @thinkgareth : NoMethodError - undefined method `get_sidekiq_options' after applying this fix. I don't think this PR fixes that..

[disbelief]

@rajagopals I too was still hitting this get_sidekiq_options error with the latest. I've submitted PR #17 to deal with string worker_class arguments passed to the client middleware.

[mhenrixon]

Thanks to @disbelief we have a new version released that should take care of this.

[rajagopals]

Thanks!

On Sunday, June 23, 2013, Mikael Henriksson wrote:

Thanks to @disbelief https://github.com/disbelief we have a new version
released that should take care of this.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/16#issuecomment-19879758
.