Calculate worker's unique args when a proc or a symbol is specified #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| class CustomQueueJobWithFilterMethod < CustomQueueJob | |||
| sidekiq_options unique: :until_executed, unique_args: :args_filter | |||
|
|
|||
| def self.args_filter(*args) | |||
| def self.args_filter(args) | |||
There was a problem hiding this comment.
I obviously forgot to remove splatting of arguments in a few places!
|
Thank you for the contribution, was a great find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
There was a bug which made it so job's unique digest was calculated incorrectly when worker's unique_args option was specified. If unique_args was any thuthy value (e.g. a proc or a symbol), then at line 23 in file lib/sidekiq_unique_jobs/unique_args.rb nothing happened and unique_args calculation actually never took place.
I fixed this line and modified specs to test unique_digest generation for different cases of worker options.
Also I had to fix two existing test worker classes, because they were written with assumption that arguments are passed separately, but in fact in current implementation unique_args method or proc receive arguments as a single array, which by the way contradicts some examples in README file.
This PR should fix #138.