Revert broken fix and add failing specs #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its normal queue" This reverts commit 6a66815.
| @@ -71,10 +95,10 @@ def perform(_) | |||
|
|
|||
| it 'enqueues previously scheduled job' do | |||
| QueueWorker.sidekiq_options unique: true | |||
| jid = QueueWorker.perform_in(60 * 60, 1, 2) | |||
| QueueWorker.perform_in(60 * 60, [1, 2]) | |||
There was a problem hiding this comment.
I think this test is still broken and isn't testing for a job moving from the scheduled to its normal queue.
Right now this line is creating a scheduled job with a single argument of a two element array and the later Sidekiq::Client.push is creating a job with two Fixnum arguments. It's not the same job and the test is only showing that two separate jobs can be created, not that the same job can move from the scheduled to a normal queue.
Changing this line to QueueWorker.perform_in(60 * 60, 1, 2) should be enough to demonstrate the issue
There was a problem hiding this comment.
Yeah that should be 1,2 not [1,2].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert for #105 which did not fix anything.
Add failing specs to master then it would be preferable for everyone to know that the current Master is broken.
(If this is not promptly being resolved #101 has been outstanding for a while now) (Currently our application is on 3.0.13, which still has unresolved problems but not as bad as the current Head).