Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning for redis behaviour change in 5.0 #579

Closed
ghost opened this issue Mar 17, 2021 · 2 comments · Fixed by #583
Closed

Deprecation warning for redis behaviour change in 5.0 #579

ghost opened this issue Mar 17, 2021 · 2 comments · Fixed by #583
Assignees
@mhenrixon
Labels
bug v7.x

Comments

@ghost
Copy link

ghost commented Mar 17, 2021

Describe the bug
There is a deprecation warning in Sidekiq output complaining about a line of code in sidekiq-unique-jobs

Redis#exists(key)will return an Integer in redis-rb 4.3.exists?returns a boolean, you should use it instead. To opt-in to the new behavior now you can set Redis.exists_returns_integer = true. To disable this message and keep the current (boolean) behaviour of 'exists' you can setRedis.exists_returns_integer = false`, but this option will be removed in 5.0.

It references this line:
https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb#L127
@mhenrixon
Copy link
Owner

mhenrixon commented Mar 18, 2021 •
edited
Loading

DOH @MichaelM-Shopify! I knew toggling it in the test suite was a bad idea.

I'll see if I can support another way. Will keep you posted

@mhenrixon mhenrixon self-assigned this Mar 18, 2021
mhenrixon added a commit that referenced this issue Mar 18, 2021
@mhenrixon
Prefer conn.exists? when possible
35afbd1 
Close #579
@mhenrixon mhenrixon mentioned this issue Mar 18, 2021
Merged
mhenrixon added a commit that referenced this issue Mar 18, 2021
@mhenrixon
Prefer conn.exists? when possible (#583)
58d6190 
* Don't reap :RUN keys when active

There is no harm in skipping these from being reaped, they will get reaped next time instead.

* Mandatory rubocop commit

* Prefer `conn.exists?` when possible

Close #579

* Ignore recent changes

* Reduce resource consumption on Github Actions
@mhenrixon
Copy link
Owner

Released as v7.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhenrixon mhenrixon

Labels
bug v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefer conn.exists? when possible mhenrixon/sidekiq-unique-jobs
1 participant
@mhenrixon