-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix key-value writing: no space allowed after ':=' identifier #69
Conversation
per the NRRD documentation: http://teem.sourceforge.net/nrrd/format.html#general.2 """ Each of the "<key>:=<value>" lines specifies a key/value pair in the nrrd. These can appear in NRRD0002 (and higher version) files, but not NRRD0001 files. The key and value strings are delimited by the first ":=" to appear on the line: any spaces before or after ":=" are assumed part of the key or value, respectively. """
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 6 6
Lines 357 357
Branches 114 114
=======================================
Hits 312 312
Misses 22 22
Partials 23 23
Continue to review full report at Codecov.
|
Good catch! 👍 Do you think we should not remove whitespace from the key/value pairs when reading NRRD files? Personally, I lean towards no because I can't think of any useful reason of having whitespace in the value. And, when I merge this in (I'll try to tonight), I'll probably wait to release the next version unless you really need these changes now. Hopefully a few more PRs come in soon and I can make a larger release. |
Agree, try to stick to spec when possible. I think some readers de-facto allow whitespace after the |
Hi @addisonElliott , can we get a release incorporating @ihnorton 's latest changes? |
Sure, I'll release a new version tonight. |
v0.3.5 Released! 🎉 |
Thanks @addisonElliott . We have also switched to the release version. |
This was changed in #57
but per the NRRD documentation: http://teem.sourceforge.net/nrrd/format.html#general.2
"""
Each of the ":=" lines specifies a key/value pair in the nrrd. These can appear in NRRD0002 (and higher version) files, but not NRRD0001 files. The key and value strings are delimited by the first ":=" to appear on the line: any spaces before or after ":=" are assumed part of the key or value, respectively.
"""