Portable shell wrappers #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markusduffek could you try to make the powershell wrapper also portable like this, and test that it works? Also, is the You can make a commit on top of this branch in your fork and I can cherry-pick it. |
mgunyho
force-pushed
the
portable-shell-wrappers
branch
3 times, most recently
from
b98857e to
ba3ee7e
Compare
Tested that this works with both bash & zsh
Tested that this works. A bit confusing because the bin has the same name as the alias, but looks like xonsh handles it fine.
Tested.
I suppose that fish is more well-known
mgunyho
force-pushed
the
portable-shell-wrappers
branch
from
ba3ee7e to
f2fadf0
Compare
added 7 commits
August 6, 2022 17:22
Tested that leaving out the exe works on Windows
Tested with powershell on windows. The "Get-Command -CommandType Application tere" ensures that we refer to tere.exe, and not the alias, so we don't get recursion. Basically equivalent to bash "command tere".
This way it's a bit clearer which instruction belongs to which section
mgunyho
force-pushed
the
portable-shell-wrappers
branch
from
86ba3e9 to
5c84d9e
Compare
Yes, sure. |
|
Actually, I was able to test this on Windows and I was able to figure it out (see 204e0de) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the discussion in #46.