Added sanity check: is Google Analytics loaded? #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a very small tweak that makes sure
gais actually defined before calling it.Since Google Analytics is typically loaded asynchronously and sometimes even by Google Tag Manager which itself is loaded asynchronously, it's possible for
gato be late to the party.This oughtta make sure we never call an undefined function.
By the way: I'm not sure why my
distversion includes comments where yours doesn't. I built using the supplied Gruntfile in the main repo. If you have any idea how to fix that I'll gladly edit my pull request.