Skip to content

Commit

Permalink
Do not use -race flag in upgrade tests (openshift-knative#829)
Browse files Browse the repository at this point in the history
The test suite occasionally fails with a race condition in triggering
the continual tests. Disabling the -race flag should not have effect on
how individual tests run. The tests are re-used from other repositories.
When the issue with the upgrade framework is fixed this can be enabled
again.
  • Loading branch information
mgencur authored Feb 17, 2021
1 parent 500f502 commit a1508a4
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions test/lib.bash
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function go_test_e2e {
[[ -n "$arg" ]] && go_test_args+=("$arg")
done
set +Eeuo pipefail
report_go_test -race -count=1 "${go_test_args[@]}"
report_go_test -count=1 "${go_test_args[@]}"
retcode=$?
set -Eeuo pipefail

Expand Down Expand Up @@ -77,7 +77,7 @@ function serverless_operator_e2e_tests {
done
kubeconfigs_str="$(array.join , "${kubeconfigs[@]}")"

go_test_e2e -failfast -tags=e2e -timeout=30m -parallel=1 ./test/e2e \
go_test_e2e -race -failfast -tags=e2e -timeout=30m -parallel=1 ./test/e2e \
--channel "$OLM_CHANNEL" \
--kubeconfigs "${kubeconfigs_str}" \
"$@"
Expand All @@ -96,7 +96,7 @@ function serverless_operator_kafka_e2e_tests {
done
kubeconfigs_str="$(array.join , "${kubeconfigs[@]}")"

go_test_e2e -failfast -tags=e2e -timeout=30m -parallel=1 ./test/e2ekafka \
go_test_e2e -race -failfast -tags=e2e -timeout=30m -parallel=1 ./test/e2ekafka \
--channel "$OLM_CHANNEL" \
--kubeconfigs "${kubeconfigs_str}" \
"$@"
Expand All @@ -116,7 +116,7 @@ function downstream_serving_e2e_tests {
# Add system-namespace labels for TestNetworkPolicy and ServiceMesh tests.
add_systemnamespace_label

go_test_e2e -failfast -timeout=60m -parallel=1 ./test/servinge2e \
go_test_e2e -race -failfast -timeout=60m -parallel=1 ./test/servinge2e \
--kubeconfig "${kubeconfigs[0]}" \
--kubeconfigs "${kubeconfigs_str}" \
"$@"
Expand All @@ -133,7 +133,7 @@ function downstream_eventing_e2e_tests {
done
kubeconfigs_str="$(array.join , "${kubeconfigs[@]}")"

go_test_e2e -failfast -timeout=30m -parallel=1 ./test/eventinge2e \
go_test_e2e -race -failfast -timeout=30m -parallel=1 ./test/eventinge2e \
--kubeconfig "${kubeconfigs[0]}" \
--kubeconfigs "${kubeconfigs_str}" \
"$@"
Expand All @@ -150,7 +150,7 @@ function downstream_knative_kafka_e2e_tests {
done
kubeconfigs_str="$(array.join , "${kubeconfigs[@]}")"

go_test_e2e -failfast -timeout=30m -parallel=1 ./test/extensione2e/kafka \
go_test_e2e -race -failfast -timeout=30m -parallel=1 ./test/extensione2e/kafka \
--kubeconfig "${kubeconfigs[0]}" \
--kubeconfigs "${kubeconfigs_str}" \
"$@"
Expand All @@ -167,7 +167,7 @@ function downstream_monitoring_e2e_tests {
done
kubeconfigs_str="$(array.join , "${kubeconfigs[@]}")"

go_test_e2e -failfast -timeout=30m -parallel=1 ./test/monitoringe2e \
go_test_e2e -race -failfast -timeout=30m -parallel=1 ./test/monitoringe2e \
--kubeconfigs "${kubeconfigs_str}" \
"$@"
}
Expand Down

0 comments on commit a1508a4

Please sign in to comment.