Introduce parameters to OptimalFit
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinkrahl
reviewed
Jun 22, 2021
mgeisler
force-pushed
the
optimal-fit-params
branch
5 times, most recently
from
f84add9 to
b5f734c
Compare
The hard-coded penalties only really worked for monospaced text since they made assumptions about what a gap of “5 columns” mean. Those assumptions quickly broke down when we’re talking about wrapping proportional text, as shown in the Wasm demo. This PR changes the `OptimalFit` struct so it now carries the values needed by `wrap_optimal_fit`. The Wasm demo has been adapted to show this in action – the interface is now quite crowded, and we’ll have to clean this up next. Fixes #326.
mgeisler
force-pushed
the
optimal-fit-params
branch
from
b5f734c to
01f51cd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns the hard-coded penalty constants used by
wrap_optimal_fitinto adjustable parameters. This makes it feasible to wrap proportional text using the optimal-fit algorithm.Fixes #326.