Remove uninteresting fill_boxed and fill_usize benchmarks #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought these benchmarks would tell me interesting things about how
using an `usize` for `Options` would give all sorts of inlining
benefits. In reality, I cannot measure any difference in performance
between these benchmarks, so we might as well remove them.
This has the benefit that one can do
$ cargo bench /2400
to quickly run the remaining benchmarks with a given string length.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought these benchmarks would tell me interesting things about how using an
usizeforOptionswould give all sorts of inlining benefits. In reality, I cannot measure any difference in performance between these benchmarks, so we might as well remove them.This has the benefit that one can do
to quickly run the remaining benchmarks with a given string length.