Fix #808 #986
Fix #808 #986
Conversation
|
For reference, here is what is implemented in gofumpt https://github.com/mvdan/gofumpt/blob/master/format%2Fformat.go#L334 They use a slightly different regexp You can look at historical changes, it gives context |
| @@ -165,3 +165,9 @@ func checkNumberOfArguments(expected int, args lint.Arguments, ruleName string) | |||
| panic(fmt.Sprintf("not enough arguments for %s rule, expected %d, got %d. Please check the rule's documentation", ruleName, expected, len(args))) | |||
| } | |||
| } | |||
|
|
|||
| var directiveCommentRE = regexp.MustCompile("//(line |extern |export |[a-z0-9]+:[a-z0-9])") // see https://go-review.googlesource.com/c/website/+/442516/1..2/_content/doc/comment.md#494 | |||
There was a problem hiding this comment.
I wonder if it needs to be anchored (^); I did a quick try using the comment below, and it didn't flag that as invalid;
//this is a regular command that's incorrectly formatted //nolint:foobar // because one two three(disclaimer: I only used the function directly, not in context of the whole code, so perhaps there's already some other code handling this)
There was a problem hiding this comment.
I think you are right, that's why I raised the point
|
Please note this change had a unexpected (but normal) consequence for me Previously the following syntax were allowed //nolint: somelinter // what ever the reasonThis one was somehow invalid, and excluded by the code before this PR not it reports a normal error, because it expects //nolint:somelinter // what ever the reason |
Closes #808 by ignoring comments matching the official pattern for directives