Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless failure slice declaration #1141

Merged
merged 1 commit into from
Nov 20, 2024
Merged

refactor: remove useless failure slice declaration #1141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions rule/redundant_build_tag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,26 @@ type RedundantBuildTagRule struct{}
// `//go:build` comments are automatically added by gofmt when Go 1.17+ is used.
// See https://pkg.go.dev/cmd/go#hdr-Build_constraints
func (*RedundantBuildTagRule) Apply(file *lint.File, arguments lint.Arguments) []lint.Failure {
var failures []lint.Failure

for _, group := range file.AST.Comments {
hasGoBuild := false
for _, comment := range group.List {
if strings.HasPrefix(comment.Text, "//go:build ") {
hasGoBuild = true
continue
}

if hasGoBuild && strings.HasPrefix(comment.Text, "// +build ") {
failures = append(failures, lint.Failure{
return []lint.Failure{{
Category: "style",
Confidence: 1,
Node: comment,
Failure: `The build tag "// +build" is redundant since Go 1.17 and can be removed`,
})
return failures
}}
}
}
}

return failures
return []lint.Failure{}
}

// Name returns the rule name.
Expand Down