Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 12 #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

AtosJanetW
Copy link

@AtosJanetW AtosJanetW commented Jan 27, 2022

Hi, I needed to use this package in an Angular 12 project and was unable to find an alternative package which allowed me to resize in 2 directions at once by dragging corner, so I copied it and upgraded. Passing upgraded code back to you in case you'd like to upgrade the original package.

  1. Upgraded from Angular 4 to Angular 12 by creating a new empty Angular 12 project, copying in the code files and upgrading. (I've committed the structural changes as a separate commit to make it clearer to see what has changed).
  2. Upgraded to use eslint instead of tslint.
  3. Changed ngresizable.component.ts to only listen for mousemove while dragging to prevent unnecessary event handling.
  4. Tested thoroughly in a browser (but not tested on a mobile)
    Please let me know if you need any more details. (This is my first pull request, so apologies for any mistakes in protocol!)

re-structure directories to get it into right structure for later versions of Angular
rename directory ngresizable-fork-jw to ngresizable
1. Upgrade to Angular 12
2. Upgrade to use eslint
3. Change ngresizable.component.ts to only listen for mousemove while dragging
@AtosJanetW AtosJanetW changed the title Mr32 changes Upgrade to Angular 12 Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant