Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rule): add deprecation message for 'angular-whitespace' #765

Merged
merged 1 commit into from
Feb 17, 2019
Merged

refactor(rule): add deprecation message for 'angular-whitespace' #765

merged 1 commit into from
Feb 17, 2019

Conversation

rafaelss95
Copy link
Collaborator

Once someone tries to use angular-whitespace rule will receive the following message:

angular-whitespace is deprecated. Use a formatter like Prettier for formatting purposes.

@rafaelss95 rafaelss95 requested review from mgechev and wKoza February 16, 2019 00:22
wKoza
wKoza approved these changes Feb 16, 2019
View reviewed changes
Copy link
Collaborator

@wKoza wKoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgechev mgechev merged commit bc5a7ec into mgechev:master Feb 17, 2019
@rafaelss95 rafaelss95 deleted the refactor/angular-whitespace-deprecation-message branch February 18, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wKoza wKoza wKoza approved these changes

@mgechev mgechev mgechev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaelss95 @mgechev @wKoza