Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(allow-template-call-expression): allow $any in expressions #735

Merged

Conversation

mattlewis92
Copy link
Contributor

Hey Minko and co!

$any can be used to bypass issues with template typings when fullTemplateTypeCheck is on, but codelyzer doesn't seem to know about it, this PR fixes that

I'm not very familiar with how this project works so I've got a few open questions about my implementation:

  1. Should the fix be applied in visitFunctionCall as well?
  2. Should the fix be applied to the parent RecursiveAngularExpressionVisitor class instead?
  3. Should a new rule be added (in a follow up PR) to disallow the use of $any, similar to the tslint rule?

Copy link
Collaborator

@wKoza wKoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wKoza
Copy link
Collaborator

wKoza commented Jan 30, 2019

Thanks @mattlewis92 ,

1- visitMethodCall seems to be the good place for $any() ;
2 - No, your are in the good place also.
3 - You can propose a rule in that

@mgechev mgechev merged commit a75c204 into mgechev:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants