fix: support validation directives and extra suffixes #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow `Validator` suffix if any of the implemented interfaces by a directive ends with `Validator`. - Allow multiple suffixes for a directive. Fix #397
wKoza
reviewed
Sep 8, 2017
src/directiveClassSuffixRule.ts
Outdated
| if (t.expression && t.expression.name) { | ||
| return t.expression.name.text; | ||
| } | ||
| return t.expression.text; |
There was a problem hiding this comment.
t.expression is never null ? if this is the case => if (t.expression.name)
wKoza
approved these changes
Sep 8, 2017
|
Travis gives us |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validatorsuffix if any of the implemented interfaces by adirective ends with
Validator.Fix #397