fix : change metadata rule

src/bananaInBoxRule.ts

@@ -5,23 +5,23 @@ import {BasicTemplateAstVisitor} from './angular/templates/basicTemplateAstVisit
 import {NgWalker} from './angular/ngWalker';
 
 
-const BoxInABananaOpen = '([';
-const BoxInABananaClose = '])';
-const BananaInABoxOpen = '[(';
-const BananaInABoxClose = ')]';
-const BoxInABananaRe = new RegExp('\\(\\[(.*?)\\]\\)(.*?)');
+const InvalidSyntaxBoxOpen = '([';
+const InvalidSyntaxBoxClose = '])';
+const ValidSyntaxOpen = '[(';
+const ValidSyntaxClose = ')]';
+const InvalidSyntaxBoxRe = new RegExp('\\(\\[(.*?)\\]\\)(.*?)');
 
 const getReplacements = (text: ast.BoundEventAst, absolutePosition: number) => {
   const expr: string = (text.sourceSpan as any).toString();
-  const internalStart = expr.indexOf('([');
-  const internalEnd = expr.lastIndexOf('])');
-  const len = internalEnd - internalStart - BoxInABananaClose.length;
-  const trimmed = expr.substr(internalStart + BoxInABananaOpen.length, len).trim();
+  const internalStart = expr.indexOf(InvalidSyntaxBoxOpen);
+  const internalEnd = expr.lastIndexOf(InvalidSyntaxBoxClose);
+  const len = internalEnd - internalStart - InvalidSyntaxBoxClose.length;
+  const trimmed = expr.substr(internalStart + InvalidSyntaxBoxOpen.length, len).trim();
 
   return [
     new Lint.Replacement(absolutePosition,
-      internalEnd - internalStart + BoxInABananaClose.length,
-      `${BananaInABoxOpen}${trimmed}${BananaInABoxClose}`)
+      internalEnd - internalStart + ValidSyntaxClose.length,
+      `${ValidSyntaxOpen}${trimmed}${ValidSyntaxClose}`)
   ];
 };
 
@@ -33,12 +33,12 @@ class BananaInBoxTemplateVisitor extends BasicTemplateAstVisitor {
       // Note that will not be reliable for different interpolation symbols
       let error = null;
       const expr: any = (<any>prop.sourceSpan).toString();
-        if (BoxInABananaRe.test(expr)) {
-        error = 'The box is in a banana! Expecting Banana in a box [(expr)]';
+        if (InvalidSyntaxBoxRe.test(expr)) {
+        error = 'Invalid binding syntax. Use [(expr)] instead';
       }
 
       if (error) {
-        const internalStart = expr.indexOf(BoxInABananaOpen);
+        const internalStart = expr.indexOf(InvalidSyntaxBoxOpen);
         const start = prop.sourceSpan.start.offset + internalStart;
         const absolutePosition = this.getSourcePosition(start);
 
@@ -56,8 +56,8 @@ export class Rule extends Lint.Rules.AbstractRule {
   public static metadata: Lint.IRuleMetadata = {
     ruleName: 'banana-in-box',
     type: 'functionality',
-    description: `Ensure that properties and methods accessed from the template are public.`,
-    rationale: `When Angular compiles the templates, it has to access these properties from outside the class.`,
+    description: `Ensure that the two-way data binding syntax is correct.`,
+    rationale: `The parens "()" should have been inside the brackets "[]".`,
     options: null,
     optionsDescription: `Not configurable.`,
     typescriptOnly: true,
@@ -73,4 +73,4 @@ export class Rule extends Lint.Rules.AbstractRule {
           templateVisitorCtrl: BananaInBoxTemplateVisitor,
         }));
   }
-}
+}

test/bananaInBoxRule.spec.ts

@@ -28,7 +28,7 @@ describe('banana-in-box', () => {
       `;
       assertAnnotated({
         ruleName: 'banana-in-box',
-        message: 'The box is in a banana! Expecting Banana in a box [(expr)]',
+        message: 'Invalid binding syntax. Use [(expr)] instead',
         source
       });
     });
@@ -46,7 +46,7 @@ describe('banana-in-box', () => {
       `;
       const failures =  assertAnnotated({
         ruleName: 'banana-in-box',
-        message: 'The box is in a banana! Expecting Banana in a box [(expr)]',
+        message: 'Invalid binding syntax. Use [(expr)] instead',
         source
       });