fix: component selector name

Throw more explicit error saying that a dash is required. Fix #192
mgechev · Dec 21, 2016 · 3d53a18 · 3d53a18
1 parent 36f5cb4
commit 3d53a18
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/selectorNameBase.ts b/src/selectorNameBase.ts
@@ -63,10 +63,6 @@ export abstract class SelectorRule extends Lint.Rules.AbstractRule {
         this));
   }
 
-  public getFailureString(failureConfig): string {
-    return sprintf(failureConfig.fail, failureConfig.className, this.getOptions().ruleArguments, failureConfig.selector);
-  }
-
   public abstract getTypeFailure(): any;
   public abstract  getNameFailure(): any;
   protected abstract getSinglePrefixFailure(): any;
@@ -81,7 +77,7 @@ export abstract class SelectorRule extends Lint.Rules.AbstractRule {
   }
 
   private setMultiPrefix(prefix:string) {
-    this.isMultiPrefix = typeof prefix==='string';
+    this.isMultiPrefix = typeof prefix ==='string';
   }
 
   private setPrefixArguments(prefix:any) {
@@ -153,7 +149,11 @@ export class SelectorValidatorWalker extends Lint.RuleWalker {
             let error = sprintf(this.rule.getTypeFailure(), className,this.rule.getOptions().ruleArguments[0]);
             this.addFailure(this.createFailure(i.getStart(), i.getWidth(),error));
           } else if (!validateSelectors(this.rule.validateName.bind(this.rule))) {
-            let error = sprintf(this.rule.getNameFailure(),className,this.rule.getOptions().ruleArguments[2]);
+            let name = this.rule.getOptions().ruleArguments[2];
+            if (name === 'kebab-case') {
+              name += ' and include dash';
+            }
+            let error = sprintf(this.rule.getNameFailure(), className, name);
             this.addFailure(this.createFailure(i.getStart(), i.getWidth(), error));
           } else if (!validateSelectors(this.rule.validatePrefix.bind(this.rule))) {
             let error = sprintf(this.rule.getPrefixFailure(),className,this.rule.prefixArguments);

diff --git a/test/componentSelectorRule.spec.ts b/test/componentSelectorRule.spec.ts
@@ -194,7 +194,7 @@ describe('component-selector-name', () => {
       })
       class Test {}`;
             assertFailure('component-selector', source, {
-                message: 'The selector of the component "Test" should be named kebab-case ($$05-02$$)',
+                message: 'The selector of the component "Test" should be named kebab-case and include dash ($$05-02$$)',
                 startPosition: {
                     line: 2,
                     character: 18
@@ -213,7 +213,7 @@ describe('component-selector-name', () => {
       })
       class Test {}`;
             assertFailure('component-selector', source, {
-                message: 'The selector of the component "Test" should be named kebab-case ($$05-02$$)',
+                message: 'The selector of the component "Test" should be named kebab-case and include dash ($$05-02$$)',
                 startPosition: {
                     line: 2,
                     character: 18