Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to MRML 3.1.0 #28

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Upgrade to MRML 3.1.0 #28

merged 2 commits into from
Mar 16, 2024

Conversation

jaredculp
Copy link
Contributor

Great developer instructions! I was able to make this change with basically no knowledge of rust. Pulling in the fix for this issue, which allows using css files with mj-include.

@jaredculp
Copy link
Contributor Author

@mgd020 please review at your convenience! Does merging this PR automatically publish a new release of mjml-python?

@mgd020
Copy link
Owner

mgd020 commented Mar 15, 2024

@mgd020 please review at your convenience! Does merging this PR automatically publish a new release of mjml-python?

No, I need to create a new release with new version tagged.

Copy link
Owner

@mgd020 mgd020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please update package.version to 1.3.2 in Cargo.toml file so I can create a new release for it.

@jaredculp
Copy link
Contributor Author

@mgd020 done!

@mgd020 mgd020 merged commit 002e7ad into mgd020:master Mar 16, 2024
@mgd020
Copy link
Owner

mgd020 commented Mar 16, 2024

Released in v1.3.2!

@jaredculp jaredculp deleted the mrml-3.1.0 branch March 18, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants