Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
138549: roachtest: terminate gossip roachtest on VM migration r=arulajmani a=arulajmani

We've seen unexpected clock jumps in this test's failures. Live migrations are one explanation for this, so let's disable them for this test.

NB: Not closing out the linked issue as it happened on Azure, and this termination policy only applies to GCE.

Informs cockroachdb#130737

Release note: None

Co-authored-by: Arul Ajmani <[email protected]>
  • Loading branch information
craig[bot] and arulajmani committed Jan 8, 2025
2 parents 569e084 + 1de3581 commit 56e61b0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/cmd/roachtest/tests/gossip.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/option"
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/registry"
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/roachtestutil"
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/spec"
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test"
"github.com/cockroachdb/cockroach/pkg/gossip"
"github.com/cockroachdb/cockroach/pkg/roachprod"
Expand Down Expand Up @@ -182,7 +183,7 @@ SELECT node_id
r.Add(registry.TestSpec{
Name: "gossip/chaos/nodes=9",
Owner: registry.OwnerKV,
Cluster: r.MakeClusterSpec(9),
Cluster: r.MakeClusterSpec(9, spec.TerminateOnMigration()),
CompatibleClouds: registry.AllExceptAWS,
Suites: registry.Suites(registry.Nightly),
Leases: registry.MetamorphicLeases,
Expand Down

0 comments on commit 56e61b0

Please sign in to comment.