feat: allow to set cwd

[sileht]

Fixes #178

[mfussenegger]

Is this a use-case that you want to set the cwd per linter? I doubt there is a sensible cwd default other than vim.fn.getcwd, so users who want to change the working directory would then always have to modify all the linters they use?

How about adding an opts arguments to try_lint with a cwd property?
Not sure I like how impactful this is.

[sileht]

Is this a use-case that you want to set the cwd per linter?

I have no idea, I guess no.

I doubt there is a sensible cwd default other than vim.fn.getcwd, so users who want to change the working directory would then always have to modify all the linters they use?

In my previous vim experience, when I have used null-ls, ALE, (any older plugins I used)... the default was always the "project root directory" if found or buffer cwd if not. This has always worked out of the box for me.

How about adding an opts arguments to try_lint with a cwd property? Not sure I like how impactful this is.

That should work for me.

[sileht]

I updated the PR to pass the option to try_lint()

[mfussenegger]

In my previous vim experience, when I have used null-ls, ALE, (any older plugins I used)... the default was always the "project root directory" if found or buffer cwd if not. This has always worked out of the box for me.

neovim doesn't have the concept of a "project root directory".

There is actually work going on that might result in some kind of project module that would introduce such a concept. That's also the reason why I'm holding off on this for now.

[sileht]

In my previous vim experience, when I have used null-ls, ALE, (any older plugins I used)... the default was always the "project root directory" if found or buffer cwd if not. This has always worked out of the box for me.

neovim doesn't have the concept of a "project root directory".

There is actually work going on that might result in some kind of project module that would introduce such a concept. That's also the reason why I'm holding off on this for now.

Exactly, that is why I just introduced the configuration of cwd, I don't think a tool like nvim-lint should implement any "project root directory" lookup. Personally, I used a lspconfig helper to do that.

To give you an idea of my current setup, I have:

autocmd BufWritePost <buffer> lua require("post_write_tools").run_linter()

And run_linter() does something like this:

function M.run_linter()
  local lspconfig = require("lspconfig")
  local rootdir = lspconfig.util.root_pattern(".git")(vim.api.nvim_buf_get_name(0))
  local env = {PATH = rootdir .. "/.tox/pep8/bin/:" .. rootdir .. "/node_modules/.bin/:" .. vim.fn.getenv("PATH"}
  require("lint.linters.flake8").env = env
  require("lint.linters.mypy").env = env
  require("lint.linters.eslint").env = env
  require("lint").try_lint(nil, {cwd = rootdir})
end

[juanramirezc2]

I work with a monorepo structure using eslint and nested .eslintrc this will be pretty useful.

right now eslint only works if I open vim from one of the subfolders.
When i open vim from the root it doesn't pick the nested config 😞

[juanramirezc2]

Vscode has a working directories option microsoft/vscode-eslint#1170

[mfussenegger]

@sileht would you be up for rebasing this? Sorry that I let this slide for so long. I wanted to wait out a discussion around some project system on neovim core (that it didn't happen), and then got sidetracked with plenty of other stuff.

I think in general adding the opts with the cwd property is good

[sileht]

@mfussenegger done.

[mfussenegger]

Wow that was quick. Left a minor suggestion, otherwise this seems good to go.

[sileht]

Wow that was quick. Left a minor suggestion, otherwise this seems good to go.

I use it every day, so it was almost up to date