Lower timeout for terminate/disconnect request on nvim exit #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like debug adapters like js-debug-adapter take a bit to process terminate requests. The `vim.wait(500, ...)` was not enough, leading to leaked processes. Lowering the terminate/disconnect request timeout appears to solve the issue as it leads to the handle getting closed quicker. Fixes #1352
mfussenegger
force-pushed
the
exit-timeout
branch
from
6fe513f to
70974be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like debug adapters like js-debug-adapter take a bit to process
terminate requests. The
vim.wait(500, ...)was not enough, leading toleaked processes.
Lowering the terminate/disconnect request timeout appears to solve the
issue as it leads to the handle getting closed quicker.
Fixes #1352