Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discovery over MDNS for commission #15

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Add discovery over MDNS for commission #15

merged 1 commit into from
Aug 8, 2022

Conversation

mfucci
Copy link
Owner

@mfucci mfucci commented Aug 7, 2022

No description provided.

@mfucci mfucci requested a review from jdesai61 August 7, 2022 04:02
jdesai61
jdesai61 approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@jdesai61 jdesai61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this change and it works (gets to same stage with Home Assistant as before) - seems like node-matter thinks commissioning is complete, but HA does not. Regardless, the MDNS changes work fine.

@jdesai61 jdesai61 merged commit c19cbb0 into main Aug 8, 2022
@mfucci mfucci deleted the mdns-commission branch August 9, 2022 00:12
This was referenced Aug 9, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdesai61 jdesai61 jdesai61 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfucci @jdesai61