Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global side-effect #50

Merged
merged 1 commit into from
Nov 23, 2018
Merged

Remove global side-effect #50

merged 1 commit into from
Nov 23, 2018

Conversation

rowanwins
Copy link
Contributor

Hi @mfogel

We've been having a bit of trouble over at TurfJS with tree-shaking and we've been hunting a few spots where globals are being overridden.

Hopefully this PR is fairly straight-forward but let me know if you've got any questions.

Cheers
Rowan

@coveralls
Copy link

Pull Request Test Coverage Report for Build 216

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.78%

Totals Coverage Status
Change from base Build 215: 0.002%
Covered Lines: 645
Relevant Lines: 651

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 216

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.78%

Totals Coverage Status
Change from base Build 215: 0.002%
Covered Lines: 645
Relevant Lines: 651

💛 - Coveralls

@mfogel mfogel merged commit 4eb9ac1 into mfogel:master Nov 23, 2018
@mfogel
Copy link
Owner

mfogel commented Nov 23, 2018

@rowanwins thanks for the contribution

Let me know if there's other things that would make the integration with turfJS smoother/easier, happy to help out.

@rowanwins
Copy link
Contributor Author

If you could publish that change to npm that would be fab thanks @mfogel

@mfogel
Copy link
Owner

mfogel commented Nov 24, 2018

sure - I'll try to push out a new release this weekend.

mfogel pushed a commit that referenced this pull request Nov 24, 2018
@mfogel
Copy link
Owner

mfogel commented Nov 24, 2018

@rowanwins new release v0.9.2 with this change is live on npm now. cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants