Add checks: if config file exists and is writeable #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if [[ ! -w $CONFIG ]] | ||
| then | ||
| wd_print_msg $RED "\'$CONFIG\' is not writeable. Exiting." | ||
| exit 1 |
There was a problem hiding this comment.
Thanks for the contribution! Had completely forgotten about that.
Though, the commented line will be a problem. Since the script is run by including it, e.g. in the zsh plugin, this will exit the terminal it's run in and not a subshell like usual. How about making it an else if the the if-statement right below it? The script will then exit normally, but nothing will actually be run.
|
I added a new commit, that doesn't use The diff isn't pretty, but I just moved the |
|
Super! Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
wdI got errors that.warprcdidn't exist so I added a check that creates the file in case it doesn't exist, and stops the program if.warprcisn't writeable.