-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(release): bump versions to the latest release #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This sort of thing is a great idea to have, I've just never got around to it myself
I didn't expect to have so many thoughts on such an uncomplicated PR, sorry!
- name: configure git | ||
run: | | ||
git config --global user.name 'github-actions[bot]' | ||
git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these steps actually necessary? IIRC there are some defaults set up that you can use, no?
Also, whose email is this? Yours?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some testing without this step! I'm guessing the user.*
of whoever runs the workflow will be used, but am not certain...
This is a somewhat secret email used for @github-actions[bot] based on the ID and username - I tend to use it for workflow related things like this, but no problem removing it if all still works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL not having this will cause the action to error. I'm not sure of an alternative right now, but open to trying other things!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like having this magic email, but somehow I'm not surprised GitHub workflows don't have a proper solution for this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alpha-tango-kilo appreciate all of the solid suggestions! Updated things with the changes that I could figure out, but am open to more iteration as needed - just let me know! 🙏
The most recent run with these changes can be found in this action outputs and these release notes. The outputs from "parse input" can be seen as env
input variables in steps that follow like "bump versions". This run also used a v
prefix in inputs but earlier tests show this still works without a prefix.
Thanks for taking a look at this! 😄
- name: configure git | ||
run: | | ||
git config --global user.name 'github-actions[bot]' | ||
git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL not having this will cause the action to error. I'm not sure of an alternative right now, but open to trying other things!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through everything! Looks good
- name: configure git | ||
run: | | ||
git config --global user.name 'github-actions[bot]' | ||
git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like having this magic email, but somehow I'm not surprised GitHub workflows don't have a proper solution for this :)
Summary
👋 Howdy! This PR bumps version numbers and updates a date before creating a new release via GitHub Action. Motivation: c7a7223#comments
Preview
Some testing was done on this fork. Interesting commits and other things to note might include:
master
.--version
variable is updated, and the date and version values ofman wd
are also updated.Runbook
To create one of these releases, the version of the release can be entered for this action and the rest happens in workflow.
Notes
man
pages: https://www.man7.org/linux/man-pages/man7/man-pages.7.html1.2.3
and incremented until things worked 😋