Added ability to add warp points to other directories

[p1r473]

Added new function to allow you to add a bunch of directories quickly without needing to cd to them first.
addcd (path) Adds a path to your warp points with the directory's name
addcd (path) (point) Adds a path to your warp points with a custom name

[alpha-tango-kilo]

Nice job fixing the buffer issue!

Out of interest, can't you implement wd_addcd using wd_add? Is there a particular reason why you opted to keep everything separate?

Also, some tests for the new functionality would be nice :)

Final aside, it would be nice if the buffer fix was a separate PR to the new feature. That way, I could merge in the feature improvement while we work through the new feature feedback. No worries if it's too difficult to separate at this point though

[p1r473]

The reason I implemented addcd separate was because addcd and add can both take one parameter - add can take a point and addcd can take a path. What would be the best way to distinguish? Also, a path and a point have different failures such as a point can't have a slash and a path must exist as a directory

I definitely prefer it to all be in 1 function but I couldn't figure out a logical way to implement that because both can take one parameter and then it's tough to know if it's a path or a point

Sure I'll move the buffer fix to its own PR!

Thanks!

[alpha-tango-kilo]

In pseudocode, what I'm imagining is

wd_addcd() {
    cd $dir_param
    wd_add $(dirname $dir_param)
}

Would that work?

[p1r473]

Leave this with me you just sparked some ideas!

[p1r473]

boom! please review. love your feedback!

[alpha-tango-kilo]

Loving the test coverage! Just asking some questions mostly for my understanding, but I also don't see where the logic is handling wd addcd with only one arg

[p1r473]

but I also don't see where the logic is handling wd addcd with only one arg

there were 4 tests I made, this one does that:

test_wd_addcd_path_only()
{
    create_test_wp
    wd -q addcd "$WD_TEST_DIR"
    assertTrue "should successfully add default wp for directory" \
        "$(wp_exists "$(basename "$WD_TEST_DIR")")"
    destroy_test_wp
}

I've merged all the tests into one just for wd_cd now

[alpha-tango-kilo]

Looks great! Thanks for documenting the tests nicely. Just that last question I re-opened and then I'll merge & release this

[p1r473]

Answered Q

[alpha-tango-kilo]

Released as v0.7.0!